Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest strategy for enumerating remote files to be downloaded using SFTPFileTransfer #867

Open
greyp9 opened this issue Jun 8, 2023 · 1 comment

Comments

@greyp9
Copy link

greyp9 commented Jun 8, 2023

At this point in SSHJ, there is special logic to account for SFTP servers that do not supply file type information.

https://github.com/hierynomus/sshj/blob/master/src/main/java/net/schmizz/sshj/sftp/SFTPFileTransfer.java#L124-L127

That is, if the file type is UNKNOWN, the file is downloaded as if the type were REGULAR.

Seeking insight as to whether remote file enumeration logic should similarly ignore remote.getAttributes().getType() == UNKNOWN.

@greyp9
Copy link
Author

greyp9 commented Jun 8, 2023

This server behavior was observed using current Windows SolarWinds SFTP server.
https://www.solarwinds.com/free-tools/free-sftp-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant