Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBJKT Tags Broken #1324

Open
artsofsteen opened this issue Nov 1, 2021 · 9 comments
Open

OBJKT Tags Broken #1324

artsofsteen opened this issue Nov 1, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@artsofsteen
Copy link

Apparently objkt tags now only show the latest objkt per user who used the tag. These tags were an essential way to organize objkts, since there is no way to sort by collections.

I, and other users were using these tags to organize our work. I don't know what compelled this change, but it is extremely frustrating. Please fix this.

@artsofsteen artsofsteen added the bug Something isn't working label Nov 1, 2021
@AlexMerricksDesigns
Copy link

second this, tags were the only way to create a link to a collection, as in a set of photogoraphic works via the set name. now it looks like its not loading properly - see flocksourced, urbanmythologyv1, brightonbybench as examples. I hope this change can be reverted, I can see there potentially being utility to this change on tags with very large numbers of objkts, but in my view it makes older objkts progressively harder to find through the main site itself, and pushes artists away from hicetnunc itself. tags and unique tags are useful, this seems like centralised meddling in what's viewable or not - as an addage to that point, could hdao curation play a role here?

@SlightlyBearded
Copy link

Totally agree! HEN is in desperate need of some basic developments, and absent these changes I fear more and more traffic will divert from HEN itself as has been mentioned. Personally, I've had to create separate wallets for stylistically unique offerings, when I'd much rather have everything organizable under one wallet. As I prepare another drop, I find myself waiting to see if the secondary sites on XTZ might offer functionality for organization just so I won't have to use another wallet on HEN, and this makes me sad.

@crzypatchwork
Copy link
Contributor

crzypatchwork commented Nov 2, 2021

ok thanks for the reports. tags are also usually flooded by users, so the idea would be to have the most visibility for each user. it will be considered in future deploys reverting it.

@crzypatchwork
Copy link
Contributor

crzypatchwork commented Nov 2, 2021

reports as "it makes me sad, it's frustrating" are not helpful. stick to the description of the issue and a possible solution if you envision any and that's it.

@crzypatchwork
Copy link
Contributor

crzypatchwork commented Nov 2, 2021

I would also consider hosting you own tokens in a dApp as a possible way of organising your collections.

@AlexMerricksDesigns
Copy link

I appreciate the response crzypatchwork, and also appreciate that the change forms another kind of utility for larger tags. I wonder whether there could be some kind of filter which chekcs no. of users or objkts contained within a tag. For example for a photography tag I can see the change being of utility as it allows for a broader spread of artists viewable without exploring through an extremely long taglist. However if only a single artist has used a tag, the page becomes less useful, or even if only a few users (say 5) have used the tag. Perhaps it could be limited to <5 users or <100 OBJKTS have used the tag it displays them all, thereby solving the issue of extremely large tags being unweildly while maintaining the ability to use tags to create collections within hicetnunc itself.
I think that creating and hosting a collection within its own dApp is a useful thing to do, however it diminishes the role hicetnunc itself plays in the process, why, in that instance would I not create/fork the minting contract, create a custom collection contract and ask objkt (for example) to host it on their site. I wish for my artworks and collections to have a place on hicetnunc rather than hosted or created utilising customised and unique solutions.
There is a balance to be found within this, and while I can see why in part the change has been made, I think overall it is too sweeping and generalised a solution to the problem at hand.

@artsofsteen
Copy link
Author

Apologies for the unhelpful commentary - your response is much appreciated @crzypatchwork. Please understand that a custom solution is not possible for the vast majority of artists, yet organization is priceless. That said, I understand that using tags to create pseudocollections is not exactly the intented purpose for tags in the first place. I think Alex's suggestions were more helpful than even my own ideas.

@crzypatchwork
Copy link
Contributor

Perhaps it could be limited to <5 users or <100 OBJKTS have used the tag it displays them all, thereby solving the issue of extremely large tags being unweildly while maintaining the ability to use tags to create collections within hicetnunc itself.

setFeed(_.uniqBy(arr.filter(e => !res.includes(e.creator_id)), 'creator_id'))

I guess we would need some buffer for it to verify such conditions

@AlexMerricksDesigns
Copy link

I wouldn't know where to begin with that.
I wonder whether there is a dual pronged solution, as in, a first step checking with an hicdex query for the number of objkts within a tag, and if it's larger than a certain size, it checks number of creators.

Although on reflection, if it is the size of tag that is the issue, checking how many objkts are in a tag, and displaying all objkts if that number is under a certain size, else continuing with the current behaviour, may go a ways to solve the issue brought up here.

I suggested a limit higher than a single creator above so as to prevent an effective 'tag attack' against a collection label. As in, if it were that there are greater number of creators contained within a tag than one and then continuing with current behaviour, an adversarial could mint a piece with the tag being used for the collection preventing the rest of the collection from displaying.

I think that checking tag size and displaying all objkts if count is under (as I proposed above) 100, but would defer to your discretion on that (I say 100 as my collection on hicetnunc is ~64 objkts), and continuing with current behaviour if it's above, I think that would avoid the necessity for creating a buffer for creator.id checking how many creators have minted to a specific tag.

I think that it is a problem when a tag has a single creator contributing the tag page displays a single objkt, and not neccessarily the one from which the tag has been navigated to from.

I hope my comments make sense, and that there is a way to coming to a resolution through this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants