Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs version #482

Open
fgaz opened this issue Dec 21, 2023 · 1 comment
Open

Update nodejs version #482

fgaz opened this issue Dec 21, 2023 · 1 comment

Comments

@fgaz
Copy link

fgaz commented Dec 21, 2023

Nodejs 14 is end of life.
I'd like to build with a supported node version, but I'm getting compile errors because of the four-years-old nan dependency:

npm ERR! ../../nan/nan_typedarray_contents.h: In constructor 'Nan::TypedArrayContents<T>::TypedArrayContents(v8::Local<v8::Value>)':
npm ERR! ../../nan/nan_typedarray_contents.h:34:43: error: 'class v8::ArrayBuffer' has no member named 'GetContents'
npm ERR!    34 |       data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;
npm ERR!       |                                           ^~~~~~~~~~~

Updating node and other dependencies to current versions would be nice.

@b-g
Copy link
Member

b-g commented Dec 21, 2023

Sorry! This is not a low priority for us. Already hard to keep the beast going. Happy to get help a PR on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants