Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogFragment api is deprecated #105

Open
tomscholz opened this issue Aug 20, 2019 · 8 comments
Open

DialogFragment api is deprecated #105

tomscholz opened this issue Aug 20, 2019 · 8 comments
Assignees
Milestone

Comments

@tomscholz
Copy link

Hi,
I'm running into this issue where when I'm using this library, that Android Studio gives me an error, saying that the DialogFragment API is deprecated. If I've understood the Android documentation correctly, we could solve this problem by switching to the support library or to androidX.

What do you think?

Cheers,
Tom

@heysupratim
Copy link
Owner

Thanks for pointing this out. I would love to get some help on fixing this if anyone is interesting in putting out a PR for this.

If not, it will be the first thing I take up in my next lib update stretch

@heysupratim heysupratim self-assigned this Aug 23, 2019
@heysupratim heysupratim added this to the 2.1 milestone Aug 23, 2019
@fullmoon6661
Copy link

I stumbled on the same issue, any updates on androidx?

@ibrahimbroachwala
Copy link

+1 with the issue. Any updates?

@OneXeor
Copy link

OneXeor commented Nov 26, 2019

+1

@OneXeor
Copy link

OneXeor commented Nov 26, 2019

I solved it with the deprecated fragment manager from Activity
activity?.fragmentManager?.beginTransaction()?.add(picker, "")?.commit()

@carrymaster
Copy link

+1

@rollin-s
Copy link

+1

If anyone have found a solution, I'd love to have it.

@androidovshchik
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants