Skip to content
This repository has been archived by the owner on Jul 24, 2022. It is now read-only.

Adding automated tests #20

Open
2 of 13 tasks
ertrzyiks opened this issue May 16, 2018 · 3 comments
Open
2 of 13 tasks

Adding automated tests #20

ertrzyiks opened this issue May 16, 2018 · 3 comments

Comments

@ertrzyiks
Copy link
Contributor

ertrzyiks commented May 16, 2018

Hey @bhaskarmelkani

I'm using this plugin on my both blog instances and also I'm developing test utils for hexo here: https://github.com/ertrzyiks/hexo-test-utils

So I thought, I could help you cover this plugin with automated tests to prove utils in battle and add all missing functionality to those utils if we notice any. I can do actual coding part, but before I start I would like to get your consent. If you like the idea, we can discuss what testing framework to use etc.

Cheers,
Mateusz

TODO list

  • cover html minifier
    • enable option
    • exclude option
  • cover css minifier
    • enable option
    • exclude option
  • cover js minifier
    • enable option
    • exclude option
  • cover image minifier
    • enable option
    • exclude option
  • cover revisioning
@bhaskarmelkani
Copy link
Member

Hey @ertrzyiks,

Nice idea I am totally in for supporting you with it.

I personally like Jest. But if you prefer something else please feel free to suggest :)

@ertrzyiks
Copy link
Contributor Author

Let it be Jest. I used it with ava for all my plugins, so having experience with other test runner is even better.

I will start by covering the case from #16 , so even if you fix it before me we will have a regression spec anyways :)

@ertrzyiks
Copy link
Contributor Author

@bhaskarmelkani What do you think about enabling some CI like Travis?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants