Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no '<unk>' in the dictionary.pkl #37

Open
BasselAli1 opened this issue Nov 21, 2018 · 1 comment
Open

There is no '<unk>' in the dictionary.pkl #37

BasselAli1 opened this issue Nov 21, 2018 · 1 comment

Comments

@BasselAli1
Copy link

I know that there is supposed to be '<unk>' in the vocabulary so that in testing or in evaluation using validation data, the '<unk>' token will be mapped to a vector of zeros(in the glove vectors).
But I don't see that in this project. Am I right? I am still new in deep learning so maybe i am wrong 😅
screenshot from 2018-11-21 21-46-30
in the create_dictionary() function you are using all the datasets to build the vocabulary. Shouldn't we only use the train dataset? Please correct me if I am wrong 😅

@serena-li
Copy link

I know that there is supposed to be '<unk>' in the vocabulary so that in testing or in evaluation using validation data, the '<unk>' token will be mapped to a vector of zeros(in the glove vectors). But I don't see that in this project. Am I right? I am still new in deep learning so maybe i am wrong 😅 screenshot from 2018-11-21 21-46-30 in the create_dictionary() function you are using all the datasets to build the vocabulary. Shouldn't we only use the train dataset? Please correct me if I am wrong 😅

I also encountered the same problem, have you solved it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants