Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of communication: separate mpi4py-wrappers from DNDarrays #1243

Open
mrfh92 opened this issue Oct 13, 2023 · 2 comments
Open

Refactoring of communication: separate mpi4py-wrappers from DNDarrays #1243

mrfh92 opened this issue Oct 13, 2023 · 2 comments
Assignees
@mrfh92
Labels
communication enhancement New feature or request MPI Anything related to MPI communication stale

Comments

@mrfh92
Copy link
Collaborator

mrfh92 commented Oct 13, 2023 •
edited

Currently, the code wrapping mpi4py for torch.Tensor's is contained in heat/core/communication.py and not fully separated from constructions related to the DNDarray-class (e.g., computation of chunk sizes is also introduced there).

I would suggest to separate this clearly, which may also make #482 and similar work easier:

  • code wrapping mpi4py for torch.Tensor's becomes an own module of heat
  • in heat/core/communication.py this module can be used

Diclaimer: feel free to discuss other ideas for refactoring and/or that status-quo does not need changes
@mrfh92 mrfh92 added enhancement New feature or request MPI Anything related to MPI communication organizational Issues concerning organizational, structural or regulatory affairs To be discussed Requires discussion in project meeting first communication and removed organizational Issues concerning organizational, structural or regulatory affairs To be discussed Requires discussion in project meeting first labels Oct 13, 2023
@mrfh92 mrfh92 self-assigned this Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

Branch features/1243-Refactoring_of_communication_separate_mpi4py_-wrappers_from_DNDarrays created!

@mrfh92 mrfh92 mentioned this issue Nov 20, 2023
Draft
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrfh92 mrfh92

Labels
communication enhancement New feature or request MPI Anything related to MPI communication stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrfh92