Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm version for v3.15.0 reports v3.15.0-rc.2 #13040

Closed
TheMeier opened this issue May 16, 2024 · 12 comments · Fixed by #13059
Closed

Helm version for v3.15.0 reports v3.15.0-rc.2 #13040

TheMeier opened this issue May 16, 2024 · 12 comments · Fixed by #13059
Labels
bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@TheMeier
Copy link

TheMeier commented May 16, 2024

$ tar xzvf helm-v3.15.0-linux-amd64.tar.gz
linux-amd64/
linux-amd64/README.md
linux-amd64/LICENSE
$ linux-amd64/helm version
version.BuildInfo{Version:"v3.15.0-rc.2", GitCommit:"c4e37b39dbb341cb3f716220df9f9d306d123a58", GitTreeState:"clean", GoVersion:"go1.22.3"}

@yxxhero yxxhero added the bug Categorizes issue or PR as related to a bug. label May 16, 2024
@yxxhero
Copy link
Member

yxxhero commented May 16, 2024

@mattfarina could you take an review? thanks so much.

@sabre1041
Copy link
Contributor

Confirmed, seeing the same on the darwin arm64 artifacts

@erik-bershel
Copy link

We've temporary pinned 3.14.4 for GitHub Actions / Azure DevOps. Please drop a confirmation that it's expected behaviour for us to unlock updates of Helm. Thanks in advance.

@mattfarina
Copy link
Collaborator

This is interesting because the both tags point to the same commit. When this was created, the release tag was added and CI did the build. So, how do we get CI to handle the tags properly?

@mattfarina
Copy link
Collaborator

If I look at the build-cross make target the version comes from ...

git describe --tags --abbrev=0 --exact-match 2>/dev/null

When I run this in Linux environments, I get the release version. I'm not able to duplicate it.

But, the wrong version shows up in the release job and the release job checkout out the exact right tag.

We need to update the build job (GHA workflow) to make sure the VERSION environment variable is the tag, I think?

@yxxhero
Copy link
Member

yxxhero commented May 17, 2024

@mattfarina maybe we can rerelease?

@jack1902
Copy link

Encountered this due to ansible within its helm modules throwing a LooseVersion error, downgraded to an older version of helm which reports 3.x.x and things are happy again. The -rc.2 didn't play nicely within Ansible, would be great to address this (through homebrew i don't encounter this -rc.2 issue and get 3.15.0)

@TheMeier
Copy link
Author

Uhm isn't that even worse that homebrew ships a different binary?

@robertsirc
Copy link
Contributor

@TheMeier this isn't unusual in open source.

@mattfarina
Copy link
Collaborator

@TheMeier open source is about the source code rather than the builds. For example, pretty much everyone uses curl. The curl projects does not distribute binaries. Everyone gets them from their OS, package manager, etc. It's not just acceptable but expected to have different builds of the same source.

mattfarina added a commit to mattfarina/helm that referenced this issue May 22, 2024
The release process had selected the tag to use as the version
automatically. But, this presented a problem when a release
candidate and final release pointed to the same commit id. For a
long time it had automatically selected the final release. But,
we ran into a problem where it selected the RC tag instead of the
final release.

This change explicitly tells the build scripts the version to use
based on the tag passed into the CI run. It should no longer try
to self discover the version.

Closes helm#13040

Signed-off-by: Matt Farina <[email protected]>
@mattfarina
Copy link
Collaborator

The pull request at #13059 provides a simple fix. The tag is passed in as the explicit version rather than being automatically detected.

@mattfarina mattfarina added this to the 3.15.1 milestone May 23, 2024
mattfarina added a commit that referenced this issue May 23, 2024
The release process had selected the tag to use as the version
automatically. But, this presented a problem when a release
candidate and final release pointed to the same commit id. For a
long time it had automatically selected the final release. But,
we ran into a problem where it selected the RC tag instead of the
final release.

This change explicitly tells the build scripts the version to use
based on the tag passed into the CI run. It should no longer try
to self discover the version.

Closes #13040

Signed-off-by: Matt Farina <[email protected]>
(cherry picked from commit 0b64775)
@mattfarina
Copy link
Collaborator

3.15.1 is out and it contains the proper version. Problem fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants