-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot remove objects in dependent charts by setting values to null #12991
Labels
bug
Categorizes issue or PR as related to a bug.
Comments
This was referenced Apr 29, 2024
I have the same issue with Helm v3.14.4, while it was working some time ago. Will try to get my hands on older releases and check if those are working... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're seeing that we cannot remove objects in dependent charts by setting the values to
null
, they will still get included in the result.This used to work before, and this is causing apps deployed using ArgoCD to fail on probes getting introduced incorrectly (as they are defined in the dependent charts and cannot be nulled out).
This works well in ArgoCD 2.9.1, bot not in 2.9.2 which upgraded helm from 3.12.1 to 3.13.2, so the issue got introduced between those versions. I suspect this has to do something with this PR. The default template
ProcessDependencies()
got replaced withProcessDependenciesWithMerge()
, which ultimately does not remove null keys.Related issues:
null
values do not remove keys from sub-charts #12637Issue
After running
helm template . -f values.yaml
inhelm-issue
(see setup below) andvalues.yaml
:Please ignore that this is not functional this way, this is just to demonstrate the issue. In our real use case, this is causing probes getting incorrectly introduced, failing deployments in newer ArgoCD versions.
Note: we get the correct result if we do
Minimal setup:
helm-issue/Chart.yaml
:helm-issue/values.yaml
:helm-dep/templates/deployment.yaml
:helm-dep/Chart.yaml
:helm-dep/values.yaml
:(Of course,
helm dependency update
has to be run)The text was updated successfully, but these errors were encountered: