Cannot replace newline with r

[knuesel]

I love how newline are treated largely like normal characters. One thing that doesn't seem to work though is replacing them with the r key (tested using Helix 24.03):

When the cursor is on a newline, pressing r, doesn't have the expected effect of joining the lines with a comma separator.

With a larger selection, pressing s\n and Enter selects the newlines as expected, but r, doesn't replace them.

I could use Alt-J before r to first convert the newlines to space but it seems like the direct way should just work?

[dead10ck]

Can confirm, it looks like r doesn't work at all when it's on the line feed

[the-mikedavis]

Looks like this was introduced intentionally a while ago in #167 without a strong preference. I would prefer that we don't special case line endings. You can always shrink or split a selection before replacing if you don't want to replace the line endings

[kirawi]

I'm not sure if that code was changed later on, but I thing it could also lead to different behavior on other line endings since it's hardcoded to LF?

[kirawi]

I think the fix is to remove the check for a line ending here

helix/helix-term/src/commands.rs

Lines 1601 to 1605 in 855568f

	if str_is_line_ending(&cow) {
	cow
	} else {
	ch.into()
	}