New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"file modified by an external process" is noisy #10657
Comments
I can try to create a PR for this |
Yeah hashes to detect false positives would probably be good. IIRC vim does that too. Everywhere we update the timestamp we would update the hash too. (But only check hashes in case of a mismatched timestamp). It does add quite a bit of extra IO to writing a file but it's probably OK. I would use |
A lot of times I switch git branches without relaunching/reloading helix. Then upon attempting to write, it informs me that the file has been modified by an external process. The problem is that this gets emitted even if only the file timestamp changes, regardless of whether or not the file contents actually changed.
Instead, if Helix notices a timestamp change then there should be a fallback method, such as a hash of the file contents, to determine whether or not writing needs to be blocked and this message shown.
sha1_smol
would probably work well enough and is already in the dependency graph, or blake3 would be faster since it leverages mmap and parallelization.The text was updated successfully, but these errors were encountered: