Resetting terminal cursor shape after exiting helix seems broken in 24.03

[archseer]

Discussed in #10071

^{Originally posted by wyw March 31, 2024}

Screen.Recording.2024-03-31.at.21.32.39.mov

Related issue & PR:

• Helix changes terminal cursor style #2684
• Use terminfo to reset terminal cursor style #8591
• commits/553ffbc

Resetting the terminal cursor shape after exiting helix worked before the commit 553ffbc in version a276726:

Screen.Recording.2024-03-31.at.22.24.24.mov

[archseer]

Relevant comment from @kladd #8591 (comment) that I've originally missed since it was made after the PR was already merged

[pascalkuthe]

We should probably check what vim does and copy that. Terminfo is just a garden of weirdly noncompatible stuff (as is everything with terminals in general)

[lpoirothattermann]

Same behavior for me.

[kirawi]

Are we planning to backport this to 24.03? It seems like it could be a significant regression.

[kirawi]

Detection seems to be handled by the second variable on https://github.com/neovim/neovim/blob/30b94ae4942b4e82030bc079368dd7fcb5481456/src/nvim/tui/tui.c#L133

They have a dedicated function for terminfo: https://github.com/neovim/neovim/blob/30b94ae4942b4e82030bc079368dd7fcb5481456/src/nvim/tui/tui.c#L1882

https://github.com/neovim/neovim/blob/30b94ae4942b4e82030bc079368dd7fcb5481456/src/nvim/tui/tui.c#L2106-L2110
https://github.com/neovim/neovim/blob/30b94ae4942b4e82030bc079368dd7fcb5481456/src/nvim/tui/tui.c#L2143-L2173
https://github.com/neovim/neovim/blob/30b94ae4942b4e82030bc079368dd7fcb5481456/src/nvim/tui/tui.c#L2189-L2195

[pascalkuthe]

Oh god that is an abomination.

Probably need to implement that since we don't allow people to override escape sequences themselves

[kirawi]

I think we'd want to add it to this function:

helix/helix-tui/src/backend/crossterm.rs

Lines 57 to 78 in 97afd67

	pub fn from_env_or_default(config: &EditorConfig) -> Self {
	match termini::TermInfo::from_env() {
	Err(_) => Capabilities {
	has_extended_underlines: config.undercurl,
	..Capabilities::default()
	},
	Ok(t) => Capabilities {
	// Smulx, VTE: https://unix.stackexchange.com/a/696253/246284
	// Su (used by kitty): https://sw.kovidgoyal.net/kitty/underlines
	// WezTerm supports underlines but a lot of distros don't properly install it's terminfo
	has_extended_underlines: config.undercurl
	|| t.extended_cap("Smulx").is_some()
	|| t.extended_cap("Su").is_some()
	|| vte_version() >= Some(5102)
	|| matches!(term_program().as_deref(), Some("WezTerm")),
	reset_cursor_command: t
	.utf8_string_cap(termini::StringCapability::CursorNormal)
	.unwrap_or("\x1B[0 q")
	.to_string(),
	},
	}
	}

[cjbayliss]

temporary workaround for fish users using alacritty, shouldn't be to hard to adapt for other shells:

# FIXME: remove once https://github.com/helix-editor/helix/issues/10089 is fixed
function hx
    command hx $argv
    printf '\033[0 q'
end

EDIT: doesn't reset the cursor if helix is run in other ways, e.g. via git commit

[kirawi]

#6565 is related