-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make headlamp-plugin faster #1899
Comments
Are you having this issue in just the That should usually be only run once, and then the command just sits there watching for changes - with no update check done. I understand it would be more of a problem when the It could be made async, so it doesn't block the user getting work done. I think it uses npm internally, which could be switched to a direct https call. |
During the "watch" bug it was certainly annoying. But also in live demos it usually just seems like it takes too long. |
@skoeva I want to emphasize this part of my comment:
If the check is done async, then it can show the message some moments later. This avoids having state, and has the benefit that it isn't slow once a day. The user is never slowed down in their work. |
headlamp-plugin checks whether there are updates to it every time we run it. While this is nice and useful in a normal use, if we run the command repeatedly, this feature does impact dev experience by taking a long time when we may just be running a simple command, as every check takes usually 1.5-2.0 sec .
So I suggest we only check for updates a limited number of times per day. Maybe once a day is even enough.
If the update is to be skipped, we could print a message telling the user how to force check the updates.
cc/ @illume
The text was updated successfully, but these errors were encountered: