HazelcastMSSQLDialect missing support for IDENTITY and NVARCHAR types

[mgoldver]

When trying to use GenericMapStore pointing to MsSql DB table with IDENTITY column as a primary key, getting an exception stating "Unsupported column type 'int identity'".
The similar exception is thrown when table contains a column of type "NVARCHAR".

The only workaround that I was able to implement is to overwrite com.hazelcast.jet.sql.impl.connector.jdbc.mssql.HazelcastMSSQLDialect
resolveType method with the following:

    @Override
    public QueryDataType resolveType(String columnTypeName, int precision, int scale)
    {
        return switch (columnTypeName.toUpperCase(Locale.ROOT))
        {
            case "FLOAT" -> QueryDataType.DOUBLE;
            case "DATETIME2", "SMALLDATETIME" -> QueryDataType.TIMESTAMP;
            case "INT IDENTITY" -> QueryDataType.INT;
            case "NVARCHAR" -> QueryDataType.VARCHAR;
            default -> DefaultTypeResolver.resolveType(columnTypeName, precision, scale);
        };
    }

[jgardiner68]

Hi Michael,

I have added this to our internal tracking JIRA as SUP-431

James

[mgoldver]

Thanks a lot James!On May 21, 2024, at 5:44 AM, James Gardiner ***@***.***> wrote: Hi Michael, I have added this to our internal tracking JIRA as SUP-431 James —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>