Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support #89

Open
undernewmanagement opened this issue Sep 3, 2018 · 3 comments
Open

Docker support #89

undernewmanagement opened this issue Sep 3, 2018 · 3 comments

Comments

@undernewmanagement
Copy link

I've got a branch on a fork where I've wrapped things up in a Dockerfile.

https://github.com/undernewmanagement/sclack/commit/101ce775e229a1d959010dcdba482dc350d9a6f5

Currently it only installs the non-development version of requirements.txt

With blessing of admin and community I'm happy to submit pull request for review.

@duynguyenhoang
Copy link
Collaborator

Thank @undernewmanagement , let me check it and create a PR.

@Huge
Copy link

Huge commented Feb 12, 2019

Isn't CMD/ENTRYPOINT missing there?

@billymoon
Copy link

I couldn't find any Dockerfile in this repo, and the fork linked in this ticket is giving me a 404. For my own use, I made one up...

FROM alpine

RUN apk add git python3 py-pip

RUN git clone https://github.com/haskellcamargo/sclack.git \
    && cd sclack \
    && pip3 install -r requirements.txt \
    && chmod +x ./app.py

ENTRYPOINT cd /sclack && ./app.py

and build it

docker build . -t billymoon/sclack

and pushed it

docker push billymoon/sclack:latest

and now I store a config in my host machine's ssh folder which I think is a fairly safe place to keep secrets, and I use this command to fire up sclack

docker run -it -v $HOME/.ssh/.sclack:/root/.sclack billymoon/sclack

It works great, so just thought I would share on this ticket in case it is useful.

Only caveat I have found so far, is that the browser feature would not work, as the running container does not have access to the host machine browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants