Inline comment to a record constructor lead to non idempotent behavior #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #426
This branch is based on the #427 because, as I think, we should test the correct behavior for comments to the last constructor here too, but without that fix its impossible. So this pull request should be considered after that will be merged.
It seems that #354 may be related to or even partially fixed by this pull request, but as far as I see, current stylish-haskell's behavior with
LANGUAGE CPPandLINEpragmas is very strange itself, therefore I can't esablish what the right behavior should be in that case (and without enabling both of them I can't find any bug there