Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add current file to Cabal (exposed/other) modules #3595

Open
NickSeagull opened this issue May 15, 2023 · 4 comments · May be fixed by #3778
Open

Feature Request: Add current file to Cabal (exposed/other) modules #3595

NickSeagull opened this issue May 15, 2023 · 4 comments · May be fixed by #3778
Assignees
@VeryMilkyJoe
Labels
component: hls-cabal-plugin Issues related to the hls-cabal-plugin type: enhancement New feature or request

Comments

@NickSeagull
Copy link

Is your feature request related to a problem? Please describe.

Adding all project modules to the Cabal file is often confusing for newcomers, if we could add them automatically, it'd be a win.

Describe the solution you'd like

When a module in the project is opened and it is not mentioned in the Cabal file, it should be added automatically to the other-modules section.

This would be a quick boost of productivity, so the developer would only need to move the module to exposed-modules if they want to expose it.

An alternative would be to add a command to the extension to achieve this on demand.

Describe alternatives you've considered

Using/creating a CLI file just for this

Additional context

In F# Ionide this is done through an additional file explorer view, which is overkill in my opinion. Still, it frees the dev from having to mess around with tooling.
@fendor
Copy link
Collaborator

fendor commented May 15, 2023

Hi, thank you for your bug report!

The requested feature is the responsibility of Haskell Language Server, moving the issue to the main repo.

@fendor fendor transferred this issue from haskell/vscode-haskell May 15, 2023
@fendor
Copy link
Collaborator

fendor commented May 15, 2023

I think we do have a duplicate issue somewhere...

Currently, this is a huge amount of work, and cannot easily be done.
Related issue: #155

Maybe we can do something with #2940, but it won't be any time soon.

@NickSeagull
Copy link
Author

Thanks a lot for the prompt response! I understand that maintaining a great project like this is a huge effort. No push at all, just wanted to put this on the backlog in case someone might want to take a stab in the future, myself included :)

It is not said enough in the OSS community, so here it goes:

Thanks a lot for your efforts ❤️

@michaelpj michaelpj mentioned this issue Jul 7, 2023
Closed
@fendor fendor mentioned this issue Jul 8, 2023
Closed
@fendor
Copy link
Collaborator

fendor commented Jul 8, 2023 •
edited by VeryMilkyJoe

@VeryMilkyJoe is going to work on this issue as one of their next tasks for #2940

@fendor fendor mentioned this issue Aug 14, 2023
Open
@VeryMilkyJoe VeryMilkyJoe linked a pull request Aug 28, 2023 that will close this issue
Open
@georgefst georgefst mentioned this issue Oct 4, 2023
Open
@michaelpj michaelpj added type: enhancement New feature or request component: hls-cabal-plugin Issues related to the hls-cabal-plugin labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VeryMilkyJoe VeryMilkyJoe

Labels
component: hls-cabal-plugin Issues related to the hls-cabal-plugin type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement code action to add module to cabal file VeryMilkyJoe/haskell-language-server
4 participants
@michaelpj @NickSeagull @fendor @VeryMilkyJoe