Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for azurerm_application_gateway Basic SKU (Preview) #25973

Open
1 task done
tedsmitt opened this issue May 15, 2024 · 2 comments
Open
1 task done

Support for azurerm_application_gateway Basic SKU (Preview) #25973

tedsmitt opened this issue May 15, 2024 · 2 comments

Comments

@tedsmitt
Copy link

tedsmitt commented May 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

As per the announcement for the Application Gateway Basic SKU (Preview) - implement Basic as an option for the azurerm_application_gateway property sku.name and sku.tier

Following feature will be required to be registered in the subscription:
az feature register --name AllowApplicationGatewayBasicSku --namespace Microsoft.Network

Some changes to the sku.capacity and autoscale_configuration logic/defaults may need to be made as well, since the Basic SKU doesn't support this

I'm happy to look at implementing this, is the process to update to go-azure-sdk first, and then implement this in the provider?

New or Affected Resource(s)/Data Source(s)

azurerm_application_gateway

Potential Terraform Configuration

resource "azurerm_application_gateway" "this" {
  name                = "${var.prefix}-agw"
  resource_group_name = var.resource_group.name
  location            = var.resource_group.location

  sku {
    name = "Basic"
    tier = "Basic"
  }
...

References

https://azure.microsoft.com/en-us/updates/public-preview-azure-application-gateway-v2-basic-sku/#:~:text=The%20Application%20Gateway%20Basic%20SKU,require%20advanced%20traffic%20management%20features

@tedsmitt tedsmitt changed the title Support for azurerm_application_gateway Basic SKU Support for azurerm_application_gateway Basic SKU (Preview) May 15, 2024
@tedsmitt
Copy link
Author

I am writing a PR for this feature, should have it ready for review either by the end of tomorrow.

@tedsmitt
Copy link
Author

tedsmitt commented May 15, 2024

Upgrade of the applicationgateways API version is required

Application Gateway Name: "acctestag-xxx"): performing CreateOrUpdate: unexpected status 400 (400 Bad Request) with error: ApplicationGatewayPropertyNotSupportedApiVersionTooOld: Specified api-version '2022-07-01' does not support property 'Basic' in context '/subscriptions/xxx/resourceGroups/acctestRG-xxx/providers/Microsoft.Network/applicationGateways/acctestag-xxx'. Use at least api-version '2023-02-01' or remove property 'Basic' from the request body.

This might be more work than initially expected 馃槄

EDIT: Looks like this is staying on 2022-07-01 for compatibility reasons as per #25844 - so this will be blocked pending the upgrade of the api version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants