New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Empty retry_strategy of aws_batch_job_definition causes panics #37349
Labels
bug
Addresses a defect in current functionality.
crash
Results from or addresses a Terraform crash or kernel panic.
service/batch
Issues and PRs that pertain to the batch service.
Comments
Community NoteVoting for Prioritization
Volunteering to Work on This Issue
|
github-actions
bot
added
crash
Results from or addresses a Terraform crash or kernel panic.
service/batch
Issues and PRs that pertain to the batch service.
labels
May 8, 2024
terraform-aws-provider
bot
added
the
needs-triage
Waiting for first response or review from a maintainer.
label
May 8, 2024
This was referenced May 8, 2024
I started working on a fix for this |
@flostadler thank you for reporting this, let me know if you need any help with the fix. |
justinretzolk
removed
the
needs-triage
Waiting for first response or review from a maintainer.
label
May 13, 2024
flostadler
added a commit
to flostadler/terraform-provider-aws
that referenced
this issue
May 14, 2024
Computing whether a Batch JobDefinition has a diff panics if the `retry_strategy` is empty. This is a valid configuration because all properties of `retry_strategy` are optional. This patch fixes that by adding the missing nil checks for the retry strategy. Fixes hashicorp#37349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Addresses a defect in current functionality.
crash
Results from or addresses a Terraform crash or kernel panic.
service/batch
Issues and PRs that pertain to the batch service.
Terraform Core Version
1.5.7
AWS Provider Version
5.48.0
Affected Resource(s)
Creating an
aws_batch_job_definition
with an emptyretry_strategy
block causes panics after the first apply. Every operation (plan/apply/destroy) after the first apply causes a panic.Expected Behavior
No panic should be raised and plan/apply/destroy should function without errors.
Actual Behavior
All operations after the first apply crash with a panic.
Relevant Error/Panic Output Snippet
Terraform Configuration Files
Steps to Reproduce
terraform apply
(this works)terraform plan
(observe panic)Debug Output
Panic Output
No response
Important Factoids
No response
References
No response
Would you like to implement a fix?
None
The text was updated successfully, but these errors were encountered: