-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Section tag: Feature Request #116
Comments
Is |
Hiya, not an official as far as liquid goes.
as in if some one wanted to render some existing Shopify code via node It would hit a number of missing Shopify specific tags.
Ones that wouldn't make sense to add as individuals may wish to write logic around these:
I am not sure on the scope you are trying to work to, but if it is to render shopify templates via node ( my use case ), there will be these implementations that do not exist in the liquid docs. At present I am just gonna build them into a plugin for usage in my use case. :) |
That's great to have this plugin, I would like to put it into the plugin list when you're ready. |
Any update on this issue? |
I tried to make a section-tags plugin but I just find out that I'm totally not familiar with shopify sections. Anyway it could be a start point, sharing my code here: https://github.com/harttle/liquidjs-section-tags . Since this repo only support standard filters and tags given by shopify/liquid, this thread should be closed. |
@harttle what's the latest on this? |
The above mentioned repo is discontinued. But I think we should keep this issue open as people are still interested. Let’s wait for the implementation here. |
@harttle anything I can do? If you have time to get me up to speed I can dig in and get it working. |
I've transfered harttle/liquidjs-section-tags to you. Hope that can still run with latest LiquidJS, otherwise please check the migration guide. These links are also useful:
Feel free to ask any further questions on discussions page, as dev questions are also valid there, many people trying to implement their own tags/filters, others can also help you. My problem is not familiar with how |
Hi Not an issue more of a feature request, would be good to add the base tag
{% section "fName" %}
Looking at the include tag code, it looks like it would pretty much mirror that.
I may spool up and test a pr duplicating the include tag implementation :)
The text was updated successfully, but these errors were encountered: