Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section tag: Feature Request #116

Open
leighs-hammer opened this issue Mar 28, 2019 · 9 comments
Open

Section tag: Feature Request #116

leighs-hammer opened this issue Mar 28, 2019 · 9 comments
Assignees

Comments

@leighs-hammer
Copy link

Hi Not an issue more of a feature request, would be good to add the base tag {% section "fName" %}

Looking at the include tag code, it looks like it would pretty much mirror that.
I may spool up and test a pr duplicating the include tag implementation :)

@harttle
Copy link
Owner

harttle commented Mar 29, 2019

Is section an official tag? Can you make a reference to the liquid documentation?

@leighs-hammer
Copy link
Author

Hiya, not an official as far as liquid goes.
However an official tag on shopify liquid rendering so thought in context to :

A shopify compatible Liquid template engine in pure JavaScript.

as in if some one wanted to render some existing Shopify code via node It would hit a number of missing Shopify specific tags.

  • section ( include with specific capabilities )

Ones that wouldn't make sense to add as individuals may wish to write logic around these:

  • schema / endschema
  • form / endform
  • paginate / endpaginate
    ...

I am not sure on the scope you are trying to work to, but if it is to render shopify templates via node ( my use case ), there will be these implementations that do not exist in the liquid docs.

At present I am just gonna build them into a plugin for usage in my use case. :)

@harttle
Copy link
Owner

harttle commented Mar 29, 2019

That's great to have this plugin, I would like to put it into the plugin list when you're ready.

@jamelait
Copy link
Contributor

Any update on this issue?

@harttle harttle self-assigned this Jul 19, 2019
@harttle
Copy link
Owner

harttle commented Jul 21, 2019

I tried to make a section-tags plugin but I just find out that I'm totally not familiar with shopify sections. Anyway it could be a start point, sharing my code here: https://github.com/harttle/liquidjs-section-tags .

Since this repo only support standard filters and tags given by shopify/liquid, this thread should be closed.

@jsuiker
Copy link

jsuiker commented Dec 1, 2023

@harttle what's the latest on this?

@harttle
Copy link
Owner

harttle commented Dec 2, 2023

The above mentioned repo is discontinued. But I think we should keep this issue open as people are still interested.

Let’s wait for the implementation here.

@harttle harttle reopened this Dec 2, 2023
@jsuiker
Copy link

jsuiker commented Dec 2, 2023

@harttle anything I can do? If you have time to get me up to speed I can dig in and get it working.

@harttle
Copy link
Owner

harttle commented Dec 2, 2023

I've transfered harttle/liquidjs-section-tags to you. Hope that can still run with latest LiquidJS, otherwise please check the migration guide.

These links are also useful:

Feel free to ask any further questions on discussions page, as dev questions are also valid there, many people trying to implement their own tags/filters, others can also help you.

My problem is not familiar with how section works. Please ask for help when get stuck on LiquidJS problems, I can create PRs to fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants