Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Custom Cover Pages #56

Open
3 tasks
haroldtreen opened this issue May 27, 2020 · 0 comments
Open
3 tasks

Support Custom Cover Pages #56

haroldtreen opened this issue May 27, 2020 · 0 comments

Comments

@haroldtreen
Copy link
Owner

Summary

@wrobbins recently added support for user provided cover images:

haroldtreen/epub-press#34

The clients however are still very specific about what they send to the backend:

https://github.com/haroldtreen/epub-press-clients/blob/master/packages/epub-press-js/epub-press.js#L37-L54

In order for users to take advantage of the backend feature we will need to update the clients.

Acceptance Criteria

  • epub-press-js can accept the additional metadata
  • epub-press-js has docs for these new params (added here )
  • Bonus: A field is added in epub-press-chrome for the extension.
    • Additional fields should be hidden by default and only shown if expanded? Maybe we save if the user has expanded these extra fields and consistently show the fields between usages.
    • This is a stretch - another issue to followup on this would be sufficient.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant