Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement checks to prevent validator slashing #201

Open
ericsson49 opened this issue Sep 21, 2019 · 0 comments
Open

Implement checks to prevent validator slashing #201

ericsson49 opened this issue Sep 21, 2019 · 0 comments
Labels
invalid This doesn't seem right validator Validator module

Comments

@ericsson49
Copy link
Contributor

MultiValidatorService implements a check, ensuring that a proposer or an attester can propose/attest only once per slot.
However, validator spec slashing conditions are defined per epoch. I.e. there should not be two or more conflicting block/attestations signed during the same epoch.
Since, there can be forks with different shuffling, a validator may be assigned in a proposer/attester role to different slots for different slots.
It is probably extremely rare for the proposer role, but quite possible for the attester role.
So, there can happen some scenarios, when a validator assigned to a slot as an attester for one fork, then head is switched to another fork, and the same validator assigned as an attester at some later slot. So, if both slots are during the same epoch, then our implementation will violate the first slashing condition for the validator.

So, there should be logic implemented which prevents issuing an attestation more than once for any particular epoch. Analogous check should be implemented for block proposals. That also means, the information about blocks and attestations to be issues should be stored to a disk, so that the info survived crashes. See validator specs for details.

@ericsson49 ericsson49 added invalid This doesn't seem right validator Validator module labels Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right validator Validator module
Projects
None yet
Development

No branches or pull requests

1 participant