Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink NettyServer.channelsStream implementation #180

Open
ericsson49 opened this issue Sep 4, 2019 · 0 comments
Open

Rethink NettyServer.channelsStream implementation #180

ericsson49 opened this issue Sep 4, 2019 · 0 comments

Comments

@ericsson49
Copy link
Contributor

NettyServer uses UnicastProcessor as a publisher of incoming connections. Thus it supports one subscriber only. This is a problem, if one wants to implement beaconchain_peers metric, for example. As a part of metrics implementation (#178), I temporarily attached ReplayProcessor to UnicastProcessor, and used former as channels stream (by analogy to ConnectionManager client connections stream).
While it's working, the implementation should be rewised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant