Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interval Batching for Separate Callback Function #128

Open
epociask opened this issue Dec 16, 2020 · 2 comments
Open

Interval Batching for Separate Callback Function #128

epociask opened this issue Dec 16, 2020 · 2 comments

Comments

@epociask
Copy link

It would be amazing to have a separate functionality with an auxiliary callback function that instead takes a slice of records as its parameter to allow for processing of a batch records upon some time elapsed interval. It could be passed through an additional scan function called something like ScanBatch. It would invoke the reading of records from kinesis and pass them through a callback function every-time the time interval is triggered, allowing for batch reading and providing the ability for many records to be consumed at once. :)

@harlow
Copy link
Owner

harlow commented Dec 17, 2020

Hi thanks for the note. Agree that could be a nice interface. I've just used a channel in the callback func in the past, but agree this would be a little cleaner

@epociask
Copy link
Author

Thank you so much for the response, I opened up a PR for this. If you could please review it and let me know what particular needs changing that'd be incredible. Looking forward to help contribute to this awesome library :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants