Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why when computing RMSE loss, fake and real must be multiplied by 10? #3

Open
jundanl opened this issue Jul 6, 2018 · 1 comment
Open

Comments

@jundanl
Copy link

jundanl commented Jul 6, 2018

You do transforms.ToTensor() on depth after loading it. I found that PyTorch will actually do depth = depth/255.
I guess, when computing loss, it would be better to multiply 255 in order to get a correct loss. I haven't read your code thoroughly, and don't know what you have done when you preprocessed the data. I feel confused why fake and real must be multiplied by 10 when computing loss.

I'm a beginner in this field. Thanks for your great work.

@haofengac
Copy link
Owner

Hello,

Thanks for pointing this out. The script is actually for the NYUv2 dataset. I'll try to release the script for KITTI as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants