Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that regions within a sketch don't intersect #2170

Open
hannobraun opened this issue Jan 18, 2024 · 0 comments
Open

Validate that regions within a sketch don't intersect #2170

hannobraun opened this issue Jan 18, 2024 · 0 comments
Labels
topic: validation Infrastructure for checking various properties of objects, making sure they are valid. type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

Current Situation

A Region is a single continuous 2D region. For example, it might be a circle, or a polygon, or a polygon with holes. Sketch is the top-level 2D object in Fornjot, a 2-dimensional shape. It consists of multiple regions.

If the regions in a sketch were to overlap, that would make the sketch invalid. But this is neither documented nor enforced right now. We need a validation check for this.

Implementation

The new validation check would go into validate::sketch. There is already an existing check there, and numerous others in the sibling modules. Those can be used as a template for implementing the new one.

Related Issues

There are a few related issues that are currently open:

None of those issues are blockers for this one, but if work on any of them was ongoing by the time this issue is picked up, that work would have to be coordinated.

@hannobraun hannobraun added type: feature New features and improvements to existing features topic: validation Infrastructure for checking various properties of objects, making sure they are valid. labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: validation Infrastructure for checking various properties of objects, making sure they are valid. type: feature New features and improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant