-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate that coincident vertices within Sketch
are identical
#1689
Comments
Before it was in shell. This partially addresses hannobraun#1689, holding off on validating sketches until we figure out sketch-face relationship: hannobraun#1691
Before it was in shell. This partially addresses hannobraun#1689, holding off on validating sketches until we figure out sketch-face relationship: hannobraun#1691
Sketch
and Solid
are identicalSketch
are identical
I think this issue is suited for anyone looking to start contributing to Fornjot. There is an existing validation of that kind for Also adding a unit test for the new validation check would be great, but is not required. If you're feeling ambitious, |
Shapes in the Fornjot kernel are made up of objects (faces, edges, vertices, ...). Those objects are managed in a centralized data store, and their location in that store gives them a unique identity. This means that two objects that have been created at different types are never identical, even if they are equal (i.e. contain the same data).
If two vertices within a
Sketch
orSolid
are equal (or really close together) but not identical, this is a bug. If two vertices are meant to be equal, but aren't identical, then they can end up with slightly different positions, depending on various factors, which would result in an error down the line (either a approximation failure, or an invalid triangle mesh being generated). It would be best to have validation checks to protect against this.This would involve two different but similar validation checks: One for
Sketch
, one forSolid
. Those checks should use the validation configuration to determine which vertices should be identical.The text was updated successfully, but these errors were encountered: