Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate assembly 'System.Collections.Immutable.FSR.dll' with different versions detected #130

Open
mollstam opened this issue Apr 26, 2024 · 2 comments

Comments

@mollstam
Copy link
Contributor

Yo, seems like both System.Collections.Immutable.FSR.dll and System.Collections.Immutable.dll identify as System.Collections.Immutable. Not sure if vendor one can be removed, or FSR one can be internally renamed (and usages updated if needed).

Also not sure it's a problem, just popped up in Unity's Assembly loading/analysis debug log

Duplicate assembly 'System.Collections.Immutable.FSR.dll' with different versions detected, using 'Packages/com.handzlikchris.fastscriptreload/Plugins/Roslyn/2021+/System.Collections.Immutable.FSR.dll, AssemblyName=System.Collections.Immutable, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and ignoring 'Packages/com.handzlikchris.fastscriptreload/Plugins/Roslyn/2021+/System.Collections.Immutable.dll, AssemblyName=System.Collections.Immutable, Version=1.2.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.[MODES] ModeService[none].Initialize

Take care 🎉

@builder-main
Copy link

builder-main commented Jun 6, 2024

Related #73
The PR might have resolved only half of the issue. Locally it seems that I have the following changes so indeed seemed not enough. You can delete the dll in FSR folder.

git st 
        deleted:    Assets/Plugins/Roslyn/2021+/System.Collections.Immutable.dll
        deleted:    Assets/Plugins/Roslyn/2021+/System.Collections.Immutable.dll.meta
        deleted:    Assets/Plugins/Roslyn/2021+/System.Runtime.CompilerServices.Unsafe.dll
        deleted:    Assets/Plugins/Roslyn/2021+/System.Runtime.CompilerServices.Unsafe.dll.meta

@handzlikchris
Copy link
Owner

handzlikchris commented Jun 7, 2024

I think I've not added suffix to those when spliting them out into 2021+ folder. Adding .FSR to them and changing references in ASM defs if needed should sort the conflict out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants