Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods colToProp and propToCol should work properly #7031

Open
wszymanski opened this issue Jun 18, 2020 · 0 comments · May be fixed by #7144
Open

Methods colToProp and propToCol should work properly #7031

wszymanski opened this issue Jun 18, 2020 · 0 comments · May be fixed by #7144
Assignees
@wszymanski
Labels
Breaking change Docs: Content Issues related to Handsontable's documentation content enhancement

Comments

@wszymanski
Copy link
Contributor

wszymanski commented Jun 18, 2020 •
edited

Description

As described in the title, it seems that methods colToProp and propToCol may not work properly. They don't return null values for indexes beyond the table boundaries. It doesn't fit changes done within #5945. Since 8.0.0-beta.1 release methods like toPhysicalRow, toVisualColumn, etc. return null for non-existent rows/columns.

Maybe the type of indexes handled by methods isn't proper too. It may have an influence on the work of the setDataAtRowProp. Please keep in mind that this method currently has some problems. It is described within #4118.

Your environment

  • Handsontable version: 8.0.0-beta.2
@wszymanski wszymanski self-assigned this Jun 18, 2020
@wojciechczerniak wojciechczerniak added this to the June 2020 milestone Jun 18, 2020
@wojciechczerniak wojciechczerniak mentioned this issue Jun 18, 2020
Closed
204 tasks
wszymanski added a commit that referenced this issue Jul 8, 2020
@wszymanski
WIP: First changes - checking whether returning null for index beyo…
e2eab29 
…nd a table boundaries will work properly #7031
wszymanski added a commit that referenced this issue Jul 9, 2020
@wszymanski
WIP: First changes - checking whether returning null for index beyo…
47daf47 
…nd a table boundaries (the `propToCol` method) will work properly #7031
wszymanski added a commit that referenced this issue Jul 9, 2020
@wszymanski
WIP: Saving progress #7031
ebe3261
wszymanski added a commit that referenced this issue Jul 9, 2020
@wszymanski
reverted some changes #7031
abdaf57
wszymanski added a commit that referenced this issue Jul 21, 2020
@wszymanski
WIP: Reduced how the colToProp functionality #7031
c0b1549
wszymanski added a commit that referenced this issue Jul 21, 2020
@wszymanski
WIP: Changed how getAtCell inside data source works #7031
411584e
wszymanski added a commit that referenced this issue Jul 21, 2020
@wszymanski
Added extra comments in code for changes #7031
156d454
wszymanski added a commit that referenced this issue Jul 21, 2020
@wszymanski
Changes in the internal data source method #7031
1400327
wszymanski added a commit that referenced this issue Jul 21, 2020
@wszymanski
Next comments & uncommented part of code needing further investigation …
6c1b847 
…#7031
wszymanski added a commit that referenced this issue Jul 21, 2020
@wszymanski
Investigated part of code and described changes within internal sourc…
1f938be 
…e data method #7031
wszymanski added a commit that referenced this issue Jul 22, 2020
@wszymanski
Removed redundant part of code #7031
359b1ae
wszymanski added a commit that referenced this issue Jul 22, 2020
@wszymanski
Removed test - the colToProp method should handle only sutiation wh…
9677a8a 
…en as argument there is passed visual column index (an integer) #7031
wszymanski added a commit that referenced this issue Jul 22, 2020
@wszymanski
Saving just some changes #7031
d14d702
wszymanski added a commit that referenced this issue Jul 22, 2020
@wszymanski
Modified data schema within test to the proper one #7031
ce1efc9
wszymanski added a commit that referenced this issue Jul 22, 2020
@wszymanski
Fix / workaround(?) which should be described #7031
f768aa4
wszymanski added a commit that referenced this issue Jul 23, 2020
@wszymanski
Missing changes #7031
ff2d235
wszymanski added a commit that referenced this issue Jul 23, 2020
@wszymanski
Fix for the select editor #7031
6e69fba
wszymanski added a commit that referenced this issue Jul 23, 2020
@wszymanski
Reverted part of changes - methods getSourceDataAtCol and `getSourc…
b9fbc01 
…eDataAtCell` will not be fixed, `colToProp` will need yet some work #7031
wszymanski added a commit that referenced this issue Jul 23, 2020
@wszymanski
Missing changes #7031
64024c3
@wojciechczerniak wojciechczerniak removed this from the June 2020 milestone Aug 4, 2020
@wszymanski wszymanski linked a pull request Sep 22, 2021 that will close this issue
Changes in colToProp and propToCol methods #7144
Draft
9 tasks
wszymanski added a commit that referenced this issue Sep 22, 2021
@wszymanski
Fixed problem found by linter #7031
67c92c0
wszymanski added a commit that referenced this issue Sep 22, 2021
@wszymanski
Fixed problem with populating data and handling data changes in the F…
6bb854a 
…ormulas plugin #7031
wszymanski added a commit that referenced this issue Sep 23, 2021
@wszymanski
Synced code with develop #7031
f6dac72
@warpech warpech mentioned this issue Jan 27, 2022
Closed
@AMBudnik AMBudnik added the Docs: Content Issues related to Handsontable's documentation content label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wszymanski wszymanski

Labels
Breaking change Docs: Content Issues related to Handsontable's documentation content enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes in colToProp and propToCol methods handsontable/handsontable
4 participants
@wszymanski @wojciechczerniak @AMBudnik @mrpiotr-dev