Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer Docs: remplates README and js template package are incorrect #10296

Open
thilgen opened this issue Mar 19, 2023 · 2 comments · May be fixed by #10295
Open

Developer Docs: remplates README and js template package are incorrect #10296

thilgen opened this issue Mar 19, 2023 · 2 comments · May be fixed by #10295
Labels
enhancement

Comments

@thilgen
Copy link

thilgen commented Mar 19, 2023

Description

  1. examples/templates/README.md
    • Clarified the manual copy instructions
    • Fixed an error in the supplied cp command
  2. examples/templates/js/package.json
    • Attempting to run npm install with a freshly copied version of the js template results in an error
    % npm install
npm WARN workspaces vanilla-template1 in filter set, but no workspace folder present
npm WARN deprecated [email protected]: < 19.2.0 is no longer supported
npm ERR! code 1
...
    • Fix is to bump up the version of puppeteer to 14.3.0
    • Note: puppeteer:14.3.0 looks to have been in use for all the examples since Handsontable:12.1.0

Steps to reproduce

  1. Read and attempt instructions
@thilgen
Copy link
Author

thilgen commented Mar 19, 2023

PR submitted - #10295

@adrianszymanski89
Copy link
Contributor

Hi @thilgen

Thank you for catching it and creating the PR!

@adrianszymanski89 adrianszymanski89 linked a pull request Mar 20, 2023 that will close this issue
Updates to templates README and js template package #10295
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates to templates README and js template package thilgen/handsontable
3 participants
@thilgen @AMBudnik @adrianszymanski89