Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make elm a peer dependencies #370

Open
bangzek opened this issue Sep 21, 2019 · 2 comments
Open

Please make elm a peer dependencies #370

bangzek opened this issue Sep 21, 2019 · 2 comments

Comments

@bangzek
Copy link

bangzek commented Sep 21, 2019

Currently we got two elm when installing this package:
.../node_modules/create-elm-app/node_modules/elm-webpack-loader/node_modules/elm/bin/elm
.../node_modules/create-elm-app/node_modules/elm/bin/elm

FYI the upstream elm-webpack-loader already make elm a peerDependencies

@andys8
Copy link
Contributor

andys8 commented Oct 3, 2019

Maybe related: #172 (comment)

@halfzebra
Copy link
Owner

halfzebra commented Oct 13, 2019

Hello friends, thanks for raising this issue! 👍

I think there's enough reasons to move elm out of this package by now, I think it's good idea.
I'm not sure when I'll have time to work on this, most likely closer to the holiday time.

Otherwise PRs are very welcome, I'll do my best to support your efforts if you are interested in making a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants