Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change some shell function #23

Open
Vonfry opened this issue Apr 21, 2018 · 3 comments
Open

change some shell function #23

Vonfry opened this issue Apr 21, 2018 · 3 comments

Comments

@Vonfry
Copy link
Contributor

Vonfry commented Apr 21, 2018

some function and variables such as: git_prompt_info, $fg and others are only available in oh-my-zsh. Maybe we can change them to use this theme without oh-my-zsh.

Take a look at agnoster theme. URL

Although the url is in oh-my-zsh, but the theme can use without it, it uses some function defined by itself to make sure all zsh command line can use it.

@Vonfry
Copy link
Contributor Author

Vonfry commented Apr 21, 2018

Possible like #12

@halfo
Copy link
Owner

halfo commented Apr 23, 2018

This would be a really nice idea. We'd love to have some contribution for this feature. I hope you or anyone else would like to take the lead. Thanks.

@Vonfry
Copy link
Contributor Author

Vonfry commented May 5, 2018

$fg $bg and other variables are set by zsh/misc/colors which is loaded by zsh/complist.

git function, git_prompt_short_sha and git_prompt_status , can define explicitly in the theme file.

I have tried, but it failed to use on other framework.

oh-my-zsh use source to load theme, so zsh/misc/colors can work correctly. Others use zstyle or other method, which cannot use with zmodloaded ( for me ).

The best way, I think, is to use some thing like agnoster instead of colors. This may change the origin code a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants