-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not consistent use of expires_in
vs expires_at
with filters
#294
Comments
That sounds like a good idea, though probably, we should support both (the mastodon API takes them as expires_in). Not really a problem, though, can just convert the time as appropriate. However, as far as I know, the filter API as it currently is implemented works only on pre-4.0. So probably it is better to change this after making all 4.0 related updates. I'm currently taking a short break from maintenance to do some other things, dogfooding mastodon.py being one of those things, but I'll get back to it soon enough. |
The
filter_dict
, that the reading methodsMastodon.filters
orMastodon.filter
return, uses the keyexpires_at
.But the writing methods
Mastodon.filter_create
orMastodon.filter_update
useexpires_in
as a keyword.If the
filter_dict
would match the keyword parameters of the methods, it would be easier to use the unpacking operator (**) like (withid
removed from the filter_dict)Mastodon.filter_update(**filter_dict)
The text was updated successfully, but these errors were encountered: