-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open tabs should be cleared when pervane is restarted with a different directory. #112
Comments
Good catch. However, I guess this introduces some security implications. eg. we will start leaking user's "actual" dir passed as an arg into the javascript part. So inclined not to do this. Any other ideas? How i was originally planning:
|
I dont think we need to expose root dir for that. We can create a random string for each root dir and put it into a file, for instance, into root_dir/.id and then send this random id to clients. We also dont show this file in the tree. With this approach I think you cannot expose root dir from a random string. Wdyt |
Start pervane with
dir1
and open some tabs in the browser. Then, restart pervane withdir2
and refresh the browser. This refresh does not clear the open tab list and if you click on any tab, it does not get the content. I think when pervane changes the working dir and it is refreshed on the browser, open tabs list should be cleared.The text was updated successfully, but these errors were encountered: