Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marker configuration to coordinates plug-in #1498

Closed
sweco-semara opened this issue Apr 12, 2024 · 0 comments · Fixed by #1499
Closed

Add marker configuration to coordinates plug-in #1498

sweco-semara opened this issue Apr 12, 2024 · 0 comments · Fixed by #1499
Labels
module:admin module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality

Comments

@sweco-semara
Copy link
Contributor

sweco-semara commented Apr 12, 2024

Feature Request Description
The coordinates plug-in currently lacks configuration for altering marker icon, offset and scale. If changing marker image for infoclick and coordinate plug-ins, the hardcoded scale of coordinates can give very weird results (i.e. a super tiny coordinates marker, since Hajk's default marker image is huge and scaled down to 15%).

Suggested Solution
As per brief discussion in comments of a historic issue #356, it would make sense to extend the coordinates plug-in with the same admin- and config flexibility that the infoclick plug-in already has.

This would be user-friendly for Hajk administrators, since both plug-ins (infoclick and coordinates) referring to the same marker icon resource would work consistently in Hajk.

Patch
See PR #1499 for an implementation of this feature request.

@sweco-semara sweco-semara added module:client/plugin Functionality that goes into plugins in client module:admin new feature Request for adding/changing functionality labels Apr 12, 2024
@sweco-semara sweco-semara self-assigned this Apr 12, 2024
@sweco-semara sweco-semara changed the title Add configurable marker to coordinate plug-in Add marker configuration to coordinate plug-in Apr 12, 2024
@sweco-semara sweco-semara changed the title Add marker configuration to coordinate plug-in Add marker configuration to coordinates plug-in Apr 12, 2024
sweco-semara added a commit to sweco-se/hajk-fork that referenced this issue Apr 12, 2024
@sweco-semara sweco-semara linked a pull request Apr 12, 2024 that will close this issue
@sweco-semara sweco-semara removed their assignment Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:admin module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant