-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SetWindowSize() and Layout() sizes not matching at fractional display scale factors #2978
Comments
Do you have an idea how to fix this?
I'm not sure we can render something in a pixel-perfect way with 125% mode. |
No, I'd have to go through the code to figure out if some floor or ceiling is being applied too early at some point or something like that.
Ignoring macOS and retina displays and all those apple things, yes, the device scaling is indifferent for rendering pixel perfect art. Notice that I'm not saying "render pixel art perfectly at an arbitrary scale", but "being able to set a window size compatible with our pixel art" (perfect multiple). This only depends on |
Ebitengine Version
v2.7.2
Operating System
Go Version (
go version
)go1.22.2
What steps will reproduce the problem?
Running the following program with a fractional display scale factor (I tested 125%):
What is the expected result?
Layout sizes match most recently set window sizes.
What happens instead?
Running the program with device scale factor 100% makes everything work as expected:
Running the program with device scale factor 125% shows discordances:
We see that we can get to pretty much any window size, but we tend to undershoot the target value.
Running the program with device scale factor 125% and
LayoutF()
, to have a more detailed view of what might be going on internally:Here we can see that at each size increase, we keep getting further away from the target (-0.2, -0.4, -0.6) for a few steps, and then we snap back to the right size.
At first I thought the issue might be the OS not accepting certain sizes, but after the tests, I think this looks quite suspicious on Ebitengine's side.
Anything else you feel useful to add?
I wasn't sure that having SetWindowSize() and Layout() sizes match would even be possible, but after more detailed testing, I think it should be possible, this looks more like an internal scaling calculation mistake than an OS limitation.
For context, having this work correctly is useful for setting perfect windowed sizes on pixel art games.
The text was updated successfully, but these errors were encountered: