Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HacsPluginRepository.update_repository triggers asyncio execution time warnings #3512

Closed
7 tasks done
bdraco opened this issue Feb 15, 2024 · 2 comments · Fixed by #3514
Closed
7 tasks done

HacsPluginRepository.update_repository triggers asyncio execution time warnings #3512

bdraco opened this issue Feb 15, 2024 · 2 comments · Fixed by #3514
Labels
issue:backend For issues with the backend/integration

Comments

@bdraco
Copy link
Contributor

bdraco commented Feb 15, 2024

System Health details

n/a

Checklist

Describe the issue

I'm pretty sure its the time complexity of update_filenames triggering this

Reproduction steps

Enable asyncio debug, restart HA

Debug logs

2024-02-15 10:31:55.990 WARNING (MainThread) [asyncio] Executing <Task pending name='Task-12346' coro=<HacsPluginRepository.update_repository() running at /config/custom_components/hacs/utils/decorator.py:28> wait_for=<Future pending cb=[Task.task_wakeup()] created at /usr/local/lib/python3.11/asyncio/base_events.py:427> cb=[gather.<locals>._done_callback() at /usr/local/lib/python3.11/asyncio/tasks.py:764] created at /usr/local/lib/python3.11/asyncio/tasks.py:680> took 0.398 seconds
2024-02-15 10:31:56.207 WARNING (MainThread) [asyncio] Executing <Task pending name='Task-12347' coro=<HacsPluginRepository.update_repository() running at /config/custom_components/hacs/utils/decorator.py:28> wait_for=<Future pending cb=[Task.task_wakeup()] created at /usr/local/lib/python3.11/asyncio/base_events.py:427> cb=[gather.<locals>._done_callback() at /usr/local/lib/python3.11/asyncio/tasks.py:764] created at /usr/local/lib/python3.11/asyncio/tasks.py:680> took 0.217 seconds
2024-02-15 10:31:56.480 WARNING (MainThread) [asyncio] Executing <Task pending name='Task-12344' coro=<HacsPluginRepository.update_repository() running at /config/custom_components/hacs/utils/decorator.py:28> wait_for=<Future pending cb=[Task.task_wakeup()] created at /usr/local/lib/python3.11/asyncio/base_events.py:427> cb=[gather.<locals>._done_callback() at /usr/local/lib/python3.11/asyncio/tasks.py:764] created at /usr/local/lib/python3.11/asyncio/tasks.py:680> took 0.273 seconds


### Diagnostics dump

_No response_
@bdraco bdraco added the issue:backend For issues with the backend/integration label Feb 15, 2024
@hacs-bot
Copy link

hacs-bot bot commented Feb 15, 2024

Make sure you have read the issue guidelines and that you filled out the entire template.

If you have an issue identical to this, do not add comments like "same here", "i have this too", instead add a 👍 reaction to the issue description. Thanks! 👍

@ludeeus
Copy link
Member

ludeeus commented Feb 16, 2024

I can't reproduce this, but looking at update_filenames for plugins, that was horrible...
#3514 should mitigate most of the heavy parts of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue:backend For issues with the backend/integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants