Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation will only use the latest release version - not the branch I work in? #3428

Closed
4 tasks done
exetico opened this issue Jan 2, 2024 · 3 comments · Fixed by #3429
Closed
4 tasks done

Validation will only use the latest release version - not the branch I work in? #3428

exetico opened this issue Jan 2, 2024 · 3 comments · Fixed by #3429

Comments

@exetico
Copy link

exetico commented Jan 2, 2024

Describe the issue

I noticed that the validation would only work with the latest release, and not the branch I'm working in.

Debug output:

##[debug] <Plugin ExperienceLovelace/ha-floorplan> Getting documentation for version=1.0.41,filename=README.md
##[debug] Trying to download https://raw.githubusercontent.com/ExperienceLovelace/ha-floorplan/1.0.41/README.md
::INFO:: <Validation description> completed
::INFO:: <Validation topics> completed
::INFO:: <Validation information> completed
::INFO:: <Validation issues> completed
::INFO:: <Validation archived> completed
Error:  <Validation images> failed:  The repository does not have images in the Readme file (More info: https://hacs.xyz/docs/publish/include#check-images )

Here's the debug output where I'm working in a branch, not tired to any specific release.

I can see some work has been done related to #3362 in #3363, but I don't understand why the validation is tired to the latest release?

_I even ended up trying another README.md from tonyroberts/scheduler-card/main/README.md, before I noticed the debug-run option.

As a developer I expected the run to validate the current repo. Not trying to fetch the latest release. I couldn't find anything related to that in the docs, so I'm not sure if I have missed something?

Have I originally implemented the validation it in a wrong way, or?

Link to action run

https://github.com/ExperienceLovelace/ha-floorplan/actions/runs/7385800876/job/20091413836

Link to action configuration

https://github.com/ExperienceLovelace/ha-floorplan/blob/hacs-verification-issues/.github/workflows/hacs-validation.yaml

Checklist

  • I have filled out the issue template to the best of my ability.
  • I have read https://hacs.xyz/docs/issues
  • This issue is related to the HACS action.
  • This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
@hacs-bot
Copy link

hacs-bot bot commented Jan 2, 2024

Make sure you have read the issue guidelines and that you filled out the entire template.

If you have an issue identical to this, do not add comments like "same here", "i have this too", instead add a 👍 reaction to the issue description. Thanks! 👍

@ludeeus
Copy link
Member

ludeeus commented Jan 2, 2024

It seems to be limited to the doc check, the rest is using the branch https://github.com/ExperienceLovelace/ha-floorplan/actions/runs/7385800876/job/20091413836#step:4:26
Ill take a look later today.

@exetico
Copy link
Author

exetico commented Jan 2, 2024

I've made a release with the README.md in the root folder, so the problem are not vislble in the master branch anymore, but the links are still showing the issue.

Thanks ludeeus 😄 ! Sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants