-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine feasibility of switching from Font Awesome to Material UI icons #1682
Comments
The bottom line is that Material UI icons do not bloat the bundle size significantly (using the webpack bundle analyzer (https://blog.jakoblind.no/webpack-bundle-analyzer/): Without Material UI icons: Static bundle size: 5.32 MB Parsed Bundle Size: 1.69 MB Gzipped size: 482 kB With Material UI Icons (using instructions from here: https://mui.com/material-ui/material-icons/) Static bundle size: 5.47 MB Parsed Bundle Size: 1.75 MB Gzipped size: 500 kB With Material Design Icons imported via react-icons NPM package (https://react-icons.github.io/react-icons/icons/md/, the bundle size is identical to "Without Material UI Icons" above. This appears to be the same icon set as the Material UI icons mentioned above. This method also allows mix-and-matching any of the icons from the set listed here: https://react-icons.github.io/react-icons/ I would recommend
|
Overview
We want to find a larger collections of relevant free icons to use in the app than offered by the current collection of Free Font Awesome icons. One option is the Material UI icons, but that involves importing some large NPM modules as well, which might cause excessive bloat in the code base. Determine if using the Material UI icons actually causes an unacceptable increase in the size of the JavaScript downloaded to the browser.
Action Items
We need to research to see if the Material Icon libraries are useable with the app .(Tree shaking) If feasible, we will have the designers change out all the icons currently in the application designs with Material UI icons, and pass the changes to dev. Issue #1681
Resources/Instructions
Style Guide
Material Icons
The text was updated successfully, but these errors were encountered: