Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Fix ESLint problems with @typescript-eslint/ban-types #641

Open
glenflorendo opened this issue Mar 27, 2024 · 0 comments
Open

Comments

@glenflorendo
Copy link
Member

User Story

As a developer, I want to adhere to our linting rules, so that I can ensure I am writing clean, correct code and following best practices.

Description

ESLint is a popular tool that is used to analyze code and find problems based on our configured rules, which includes several nice recommendations.

This ticket focuses on the @typescript-eslint/ban-types.

You will need to understand this rule and go through the code to resolve any problems.

To see all violations for all rules, run the following command:

pnpm ci:lint

This rule should be removed from our configuration to allow the default settings to come into affect. It was merely added as an override to not block development.

Additional Context

This work is being done now in part to Ci/CD efforts. We want to enable linting in our pipeline, however, it will always fail since we currently have errors.

Acceptance Criteria

  1. Running the linter will not find any violations with this rule.
  2. This rule is removed from our configuration.

Technical References

@glenflorendo glenflorendo changed the title Fix ESLint problems with @typescript-eslint/ban-types [Tech Debt] Fix ESLint problems with @typescript-eslint/ban-types Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant