-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patchWindow.js might try to patch non-window objects and log errors #343
Comments
That link seems broken. Which browser version are you finding this in? However probably checking if the interface is there is a good idea anyway. |
I updated the link. I'm on Kubuntu 22.04, Firefox 123.0, NoScript 11.4.29 |
Is the |
Yes, |
Then what is happening is quite clear: you're adding your elements as window[number], which would normally reference subframes' window objects (where HTMLFrameElement is defined - deprecation is not the issue here). Fortunately this cannot alias the actual window objects (meant to be wrapped) if they're present, and your code won't break anyway because the exception is just logged, not rethrown, but that's annoying nonetheless, if nothing else because of the console noise. Therefore I'm fixing this in next NoScript version, thanks. |
On my SO post, I enter in detail on how I got a bug because of NoScript.
But, basically, on
patchWindow.js:291
, it's using a deprecated interfaceHTMLFrameElement
, which throws anTypeError: win[(("HTML" + (intermediate value)) + "Element")] is undefined
The text was updated successfully, but these errors were encountered: