Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avcpp is not usable as meson subproject (uninstalled) due to headers in src directory #79

Open
piotrrak opened this issue Sep 24, 2020 · 3 comments
Assignees
Labels

Comments

@piotrrak
Copy link
Contributor

Hello

As in subject when uninstalled I can't use library, because headers can't be included correctly:

#include <avcpp/av.h>
// or
#include "avcpp/av.h"

I am aware of 3 potential solutions to that, two simple, one not that simple:

I can live with my 'copy headers' workaround, didn't care yet to implement it for cmake though.

@h4tr3d
Copy link
Owner

h4tr3d commented Sep 25, 2020

I am not a Meson guru, but current layout work well for CMake projects as subproject as well. CMake is prioritized build system for me, so, I don't want to change project layout. Build system should help and should not mess :-)

@piotrrak
Copy link
Contributor Author

I am not anything guru to be honest. Please note that currently even samples are using internal include path.
This won't build with cmake or meson: samples changes. Just thought it would be nice to give users code that compiles, no matter if library is installed or not.
Installing headers workaround for meson works for me; That's option 3 I've mentioned and did not involve changing directory structure.

@h4tr3d
Copy link
Owner

h4tr3d commented Mar 5, 2021

Take a look.

@h4tr3d h4tr3d added the bug label Mar 5, 2021
@h4tr3d h4tr3d self-assigned this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants