fix: allow numeric value input for amount #411
Conversation
dhruvanbhalara
commented
Dec 10, 2023
•
dhruvanbhalara
commented
- fixes: Make the area where we enter the amount as number only. #405
- fixes: transaction input not using the correct decimator #392
| maxLength: 13, | ||
| maxLines: 1, | ||
| counterText: '', | ||
| inputFormatters: [ | ||
| FilteringTextInputFormatter.allow(RegExp(r"[0-9.]")), |
There was a problem hiding this comment.
This could lead to issues in other languages, dutch for example uses , as a decimal point
There was a problem hiding this comment.
@xunafay, I've covered this scenario.
There was a problem hiding this comment.
I've gone through all the country data in the project and I've found the following decimal & thousands separators: [ .,-']
I could confirm no missing ones with this regex: ".+_separator": "[^ '.,-]"
There was a problem hiding this comment.
@xunafay, Do you mean like this?
RegExp(r"[0-9'.,-]")There was a problem hiding this comment.
Yes, except the space is missing, in case the user types 1 000 or similar
There was a problem hiding this comment.
@xunafay, I've updated regex, can you please review it?
|
Hi @h4h13, |
|
Not please 🥺 I'm working on new things so once it's stabilized then you can change pr destination |
|
Hi @dhruvanbhalara I have updated this widget as part of the iOS keyboard is not able to dismiss while done entering the amount. if it still needs to fix add your changes and change pr to dev2 |
|
Let me know once it's finished will merge it |
dhruvanbhalara
force-pushed
the
allow_numeric_value_for_amount
branch
from
0ae2c85
to
591060c
Compare
|
Hi @h4h13, |
dhruvanbhalara
force-pushed
the
allow_numeric_value_for_amount
branch
from
591060c
to
9519258
Compare
dhruvanbhalara
force-pushed
the
allow_numeric_value_for_amount
branch
from
9519258
to
6cf299f
Compare
