Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enter handler for textbox #372

Open
VijithaEkanayake-zz opened this issue Dec 9, 2020 · 3 comments · May be fixed by #407 or #1744
Open

Add enter handler for textbox #372

VijithaEkanayake-zz opened this issue Dec 9, 2020 · 3 comments · May be fixed by #407 or #1744
Assignees
@VijithaEkanayake-zz
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@VijithaEkanayake-zz
Copy link

VijithaEkanayake-zz commented Dec 9, 2020 •
edited by mturoci

Add enter handler with similar logic onChange has.

Steps to follow:

  1. Setup project for dev.
  2. Find textbox.tsx.
  3. Implement the feature.
  4. Find textbox.py and showcase your new feature there.
  5. Add needed unit tests in textbox.test.tsx.
@VijithaEkanayake-zz VijithaEkanayake-zz added the feature Feature request label Dec 9, 2020
@VijithaEkanayake-zz VijithaEkanayake-zz self-assigned this Dec 9, 2020
@VijithaEkanayake-zz VijithaEkanayake-zz changed the title Support for adding button next to a text box Support for adding a button next to a text box Dec 9, 2020
@srini-x srini-x modified the milestone: 0.11 Dec 10, 2020
@mturoci mturoci added the ui Related to UI label Dec 10, 2020
VijithaEkanayake-zz pushed a commit that referenced this issue Dec 15, 2020
@VijithaEkanayake
Implement searchbar_card for wave
f51ee5a 
searchbar_card can be used to horizontally align textbox and button on the requirement. Fixes: #372
VijithaEkanayake-zz pushed a commit that referenced this issue Dec 15, 2020
@VijithaEkanayake
Implement searchbar_card for wave
1ec4594 
searchbar_card can be used to horizontally align textbox and button on the requirement. Fixes: #372
@VijithaEkanayake-zz VijithaEkanayake-zz mentioned this issue Dec 15, 2020
Closed
VijithaEkanayake-zz pushed a commit that referenced this issue Dec 15, 2020
@VijithaEkanayake
Implement searchbar_card for wave
ee3d4d9 
searchbar_card can be used to horizontally align textbox and button on the requirement. Fixes: #372
@lo5
Copy link
Member

lo5 commented Dec 17, 2020

The current textbox with a search icon (already supported) can double as a search box if we add enter key handling to it.

@mturoci mturoci changed the title Support for adding a button next to a text box Add enter handler for textbox Dec 17, 2020
@mturoci mturoci added the good first issue Contributions welcome! label Dec 17, 2020
@mtanco
Copy link
Contributor

mtanco commented Dec 18, 2020

related to #348

@lo5 lo5 added this to the 0.11 milestone Dec 18, 2020
@VijithaEkanayake-zz VijithaEkanayake-zz self-assigned this Dec 18, 2020
VijithaEkanayake-zz pushed a commit that referenced this issue Dec 18, 2020
@VijithaEkanayake
Add enter handler for textbox
245f308 
Fixes: #372
VijithaEkanayake-zz pushed a commit that referenced this issue Dec 18, 2020
@VijithaEkanayake
Add enter handler for textbox
5c08d95 
Fixes: #372
@VijithaEkanayake-zz VijithaEkanayake-zz linked a pull request Dec 18, 2020 that will close this issue
Open
VijithaEkanayake-zz pushed a commit that referenced this issue Dec 18, 2020
@VijithaEkanayake
Introduce submit attribute to textbox
be42109 
The implementation conditionally calls the keyup handler based on the values of the submit attribute.
Fixes: #372
VijithaEkanayake-zz pushed a commit that referenced this issue Dec 18, 2020
@VijithaEkanayake
Introduce submit attribute to textbox
54ea7d5 
The implementation conditionally calls the keyup handler based on the values of the submit attribute.
Fixes: #372
@lo5 lo5 modified the milestones: 0.11, 0.12 Jan 13, 2021
@lo5 lo5 modified the milestones: 0.12, 0.13 Feb 4, 2021
@lo5 lo5 removed this from the 0.13 milestone Mar 4, 2021
This was referenced Nov 30, 2022
Closed
Closed
@Nicolapps
Copy link
Contributor

I’m working with @sherrychen2, @monal20, and @kitty3190 on a PR for this issue (and also #1645, #495, and #1535) as part of a Software Engineering class assignment.

@Nicolapps Nicolapps mentioned this issue Nov 30, 2022
Closed
sherrychen2 added a commit to extreme-sharks/wave that referenced this issue Dec 7, 2022
@sherrychen2
feat: Add trigger_on_enter parameter to ui.inline h2oai#372
4a9623f
Nicolapps added a commit to extreme-sharks/wave that referenced this issue Dec 8, 2022
@Nicolapps
docs: Fix the textbox.py example h2oai#372
4efddaf
Nicolapps added a commit to extreme-sharks/wave that referenced this issue Dec 9, 2022
@Nicolapps
docs: add trigger_on_enter to textbox.md h2oai#372
21fa4c0
@sherrychen2 sherrychen2 linked a pull request Dec 9, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VijithaEkanayake-zz VijithaEkanayake-zz

Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
Milestone
No milestone
6 participants
@mtanco @VijithaEkanayake-zz @lo5 @Nicolapps @srini-x @mturoci