Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

Forwarding with Express integration not working #98

Open
pmcnr-hx opened this issue Jul 20, 2016 · 4 comments
Open

Forwarding with Express integration not working #98

pmcnr-hx opened this issue Jul 20, 2016 · 4 comments

Comments

@pmcnr-hx
Copy link

we were trying to integrate Rocky in our integration as a forwarding proxy to intercept requests and responses and be able to record metrics on the traffic. Rocky always seemed to hang when we tried to introduce middleware to modify the responses.

Trying to reduce noise, I then went to try the express example in the repository and, to my surprise, this also hung when processing forward traffic. I tried all x.0 Rocky releases all the way back to 0.1.0 and I could never get the example to work.

Now I'm curious if this aspect of the Express integration has ever worked. It would be great to be able to integrate Rocky in existing Express apps for this kind of use case, so it's a shame I can't get it to work. Any thoughts?

@h2non
Copy link
Owner

h2non commented Jul 21, 2016

What version of node are you running? Latest major releases may introduce breaking changes in stream and http modules. I was successfully running rocky in node v4 in production for almost a year, but lately I'm not using it.

@pmcnr-hx
Copy link
Author

I tested with both 0.12 and 4.

@h2non
Copy link
Owner

h2non commented Jul 21, 2016

There's a nodejs API issue with stream and event modules. I've to dig in detail and possibly re-implement the current response interceptor.

Express example is working for me in [email protected], there is only failing the response interceptor afaik.

@h2non h2non added the bug label Jul 21, 2016
@pmcnr-hx
Copy link
Author

Yes, it is only the response interceptor that is not working in the example. Line 59 never gets called.

@h2non h2non added this to the 0.5.0 milestone Jul 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants