Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect variable declaration in strict mode #19

Open
Ilrilan opened this issue May 17, 2019 · 2 comments
Open

Incorrect variable declaration in strict mode #19

Ilrilan opened this issue May 17, 2019 · 2 comments

Comments

@Ilrilan
Copy link
Contributor

Ilrilan commented May 17, 2019

Error in file requireg/lib/requireg.js

...
function resolve(module, dirname) {
  var i, resolver, modulePath

  for (i = 0, l = resolvers.length; i < l; i += 1) {
    resolver = resolvers[i]
   ...

In strict mode variable l must be declared before use:

  var i, l, resolver, modulePath
@h2non
Copy link
Owner

h2non commented May 17, 2019

Can you provide a PR for the fix? Thank you!

@Ilrilan
Copy link
Contributor Author

Ilrilan commented May 23, 2019

#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants