-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilise API #64
Labels
Comments
Definitively, the public interface of those functions should be managed as part of the package's public API contract. |
Is there something left to do here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Release 1.0.7 broke the specialised matchers that are still documented here https://h2non.github.io/filetype.py/v1.0.0/match.m.html
One could make the argument that these functions are internal API since they're not officially documented in the examples, so it's ok to break them without even a minor version bump.
However, given the usefulness of these functions (e.g. for scenarios in which one only looks for images -- something often encountered in web development) please expose them officially in the examples, and keep them stable.
The text was updated successfully, but these errors were encountered: