Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ParticleParameters #470

Open
4 tasks
nightm4re94 opened this issue Aug 12, 2022 · 1 comment
Open
4 tasks

Remove ParticleParameters #470

nightm4re94 opened this issue Aug 12, 2022 · 1 comment

Comments

@nightm4re94
Copy link
Member

What feature / which classes are you referring to?
ParticleParameter.

Describe what could be enhanced.
Instead of using ParticleParameters for Emitter configuration, we could slim down our API by using Attributes. Attributes are generic and offer more flexibility and in my opinion having two components with nearly identical functionality doesn't make sense.

Are there any alternatives to what you've considered? Please elaborate.
If we see a need to keep ParticleParameters specifically, we should document the difference properly.

Additional thoughts
Removing ParticleParameters would entail these changes:

  • make Attributes serializable
  • adjust Emitters to use Attributes instead of ParticleParameter
  • Rename EmitterData to EmitterAttributes
  • provide a detailed migration guide for existing projects since this is a breaking change.
@nightm4re94
Copy link
Member Author

I got really lost here. Would appreciate if at somepoint someone could help me finish my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant