Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cliff Click solution seems to be not handling collisions properly #719

Open
tivrfoa opened this issue Feb 8, 2024 · 0 comments
Open

Cliff Click solution seems to be not handling collisions properly #719

tivrfoa opened this issue Feb 8, 2024 · 0 comments

Comments

@tivrfoa
Copy link
Contributor

tivrfoa commented Feb 8, 2024

Hi @cliffclick

It seems your code relies that uhash is unique, but here is an example of collision:

  • Khān
  • Shām

https://github.com/gunnarmorling/1brc/blob/main/src/main/java/dev/morling/onebrc/CalculateAverage_cliffclick.java#L278

I discovered this because I ran your code, and the output is different for the create_measurements3.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tivrfoa