Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The prior value added twice in ThrowerMarkHarz toy generator #526

Open
ulyevarou opened this issue May 30, 2024 · 0 comments
Open

The prior value added twice in ThrowerMarkHarz toy generator #526

ulyevarou opened this issue May 30, 2024 · 0 comments
Labels
bug ❌ Something isn't working LTS/1.8 Issue applies to Long Term Support for 1.8

Comments

@ulyevarou
Copy link
Collaborator

In src/Utils/src/ParameterThrowerMarkHarz.cpp the addition of (*pvals)(i) should be removed

@@ -54,7 +54,8 @@ void ParameterThrowerMarkHarz::ThrowSet(std::vector<double> &parms)
   }
   TVectorD prod = (*chel_dec) * std_rand;
   for (int i = 0; i < npars; i++)
-    parms[i] = prod(i) + (*pvals)(i);
+    parms[i] = prod(i);
 }

since it is added later in the

void ParameterSet::throwParameters(..) ->
par.setThrowValue( par.getPriorValue() + gain_ * throwsList[iPar] );
@ulyevarou ulyevarou added the bug ❌ Something isn't working label May 30, 2024
@ClarkMcGrew ClarkMcGrew added the LTS/1.8 Issue applies to Long Term Support for 1.8 label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ❌ Something isn't working LTS/1.8 Issue applies to Long Term Support for 1.8
Projects
None yet
Development

No branches or pull requests

2 participants